Kafka tombstone message support #16962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-lyutenko
force-pushed
the
vlad-lyutenko/kafka-tombstone
branch
from
80b8a40 to
4404bb3
Compare
hashhar
approved these changes
Apr 12, 2023
|
|
||
| waitUntilTableExists(topicName); | ||
|
|
||
| // tombstone message should have all null values except key |
There was a problem hiding this comment.
do you think a test which verifies that tombstones can be differentiated from messages with all fields set to null would be useful? It would help us "document" the contract which we talked about so that users can differentiate between tombstones and actual nulls in their messages.
There was a problem hiding this comment.
Test added, we can differentiate these 2 cases by internal message_corrupt field
Praveen2112
approved these changes
Apr 12, 2023
vlad-lyutenko
force-pushed
the
vlad-lyutenko/kafka-tombstone
branch
2 times, most recently
from
c05dcd9 to
7353537
Compare
vlad-lyutenko
force-pushed
the
vlad-lyutenko/kafka-tombstone
branch
from
7353537 to
9ae48c4
Compare
wendigo
approved these changes
Apr 12, 2023
|
@mosabua this would be nice to document on how users can inspect/filter out tombstone messages if they want to. Before this change it lead to query failure. The TL;DR is:
|
hashhar
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kafka tombstone message support
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: